openzipkin/zipkin

Special case Elasticsearch 7.8+ Composable index templates

Open

#3 138 ouverte le 6 juil. 2020

Voir sur GitHub
 (1 commentaire) (1 réaction) (0 assignés)Java (3 079 forks)batch import
elasticsearchenhancementhelp wanted

Métriques du dépôt

Stars
 (16 912 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

Feature: If we prefer composable templates or otherwise prioritize our index templates, we can avoid support problems like https://github.com/openzipkin/zipkin-support/issues/23 where the template doesn't kick in due to something else matching on '*'

Rational Composeable templates are both introduced and preferred in ES 7.8+, which refers to _template as legacy ones.

This would introduce an issue of composeable template priority, either it would have to determine automatically what value should be set or be parameterizable through env variable.

Example Scenario Test would have a pre-existing composable template and ours still applies

Thanks @benqs for the hint. cc @openzipkin/elasticsearch

Guide contributeur