onivim/oni

Bug - Configuration: If there is only a `config.tsx` present, config doesn't load until saved once

Open

#2 056 ouverte le 6 avr. 2018

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)TypeScript (11 389 stars) (336 forks)batch import
bughelp wantedinsider

Description

It's common to save out the dotfiles of your config - like stashing a config.tsx somewhere, and sharing it between machines.

Repro:

  • Customize your configuration by saving a value in your config.tsx
  • Delete the config.js that is (generated) next to your config.tsx
  • Reload Oni

Expected: Configuration changes should still be present Actual: Configuration changes are not present

Oni actually uses a config.js, and when you save the config.tsx, it automatically generates the corresponding config.js. It doesn't make sense to check-in both of these, but if you only bring over a config.tsx, the config.js won't be generated until you've saved your config.tsx once.

We should detect this case (where there is a config.tsx, but no corresponding config.js) and attempt to transpile it on startup.

Guide contributeur

Stack technique
typescriptnodejs
Domaine
developer experiencetooling
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Basic TypeScriptFamiliarity with config loading
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
60
Direction de recherche
Investigate the config loading mechanism in Oni. Look for where `config.js` is generated from `config.tsx`. The fix likely involves adding a check at startup: if `config.tsx` exists but `config.js` does not, trigger the transpilation process. Relevant files may be in the configuration module, possibly around initial loading or the file watcher.