nightwatchjs/nightwatch

`frame()` command doesn't support page object element

Open

#3 655 ouverte le 25 mars 2023

Voir sur GitHub
 (7 commentaires) (0 réactions) (1 assigné)JavaScript (11 707 stars) (1 289 forks)batch import
buggood first issuehacktoberfest

Description

Description of the bug/issue

When I use frame() command, I expect the page object element can be used as a selector, but actually, it won't work.

Steps to reproduce

Try using frame() with a page object element.

Sample test

myPage.api.frame('@myIframe')

Nightwatch.js Version

2.6.14

Additional Information

See Discord discussion https://discord.com/channels/618399631038218240/1088668054650626058

David Burns - AutomatedTester — Yesterday at 21:33 I think this might need a bug raised. That doesn't seem right andrei — Today at 01:42 when using page objects, elements passed to commands on the .api namespace aren't resolved automatically. but we can easily add the frame() command on the main page object namespace Currently .frame() is implemented as a "protocol" command, so we will need to move it to the element-commands and update the implementation as needed. It's a relatively straightforward task.

Guide contributeur

Stack technique
javascriptnodejs
Domaine
testing
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Nightwatch.js basicsPage object modelJavaScript
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
70
Direction de recherche
Examine the existing implementation of `frame()` as a protocol command (likely in `nightwatch/lib/api/commands/` or similar). Look at how other element commands like `click` are implemented as element commands, including how they resolve page object elements. Then modify `frame()` to follow that pattern. Check the Discord discussion for additional context.