neos/neos-development-collection

Bug `Neos.Fusion:Match` with `@default = ${null}`

Ouverte

#3 630 ouverte le 2 mars 2022

 (3 commentaires) (0 réaction) (0 personne assignée)PHP (248 forks)auto 404
BugGood first issueP: Fusion

Métriques du dépôt

Stars
 (267 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

The MatchImplementation doesnt allow to use a default of the actual php null. It assumes it gets null because the fusion path was not found. Instead we would need to check the runtime last evaluation status.

https://github.com/neos/neos-development-collection/blob/2b27a1d372f7a54cfa847411bbdf1fc9936af45d/Neos.Fusion/Classes/FusionObjects/MatchImplementation.php#L47

steps to reproduce:

run:

root = Neos.Fusion:Match {
    @subject = ${'abc'}
    @default = ${null}
}

expect: null as result (eg. no result to see)

actual: Unhandled match Exception

More: Php 8 match allows a default of null, so we should allow it too.

Same also for matching paths like when 'abc' was defined but set to null, it would continue on to the default, as it thinks null was returned because the path is not defined.

When testing this, use an eel null instead of fusion null, as foo = null is omited while parsing

Neos since introduction of matcher

A super hacky idea: __eelExpression => "null"

Guide contributeur