mysqljs/mysql

Connections in pool have an infinite lifetime

Open

#1 276 ouverte le 12 nov. 2015

Voir sur GitHub
 (8 commentaires) (4 réactions) (0 assignés)JavaScript (18 137 stars) (2 502 forks)batch import
help wanted

Description

I have a process running all the time and when it idles for a while the connections in the pool are in a sleeping state. Eventually MySQL purges those connections based on the wait_timeout setting in my.cnf. Once this happens and I try to use a connection it will fail because the module assumes the connection is still live and tries to use it only to get a timeout or connection exception.

I would propose adding an option when creating a pool connection_lifetime which will work in a following way. When getting a connection from the pool, if the connection_lifetime is not exceeded we simply return the connection, if however it is exceeded we kill the selected free connection and create a new one in it's place. That should solve the issue.

Guide contributeur

Stack technique
javascript
Domaine
backenddatabase
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Node.jsmysql package basicsconnection pooling conceptsMySQL wait timeout
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
40
Direction de recherche
The issue proposes adding a `connection lifetime` option to the connection pool. Examine the pool implementation in `lib/Pool.js` to understand how connections are acquired and released. Review the existing comments, particularly #1276, for any additional context or alternative approaches. The solution would involve modifying the `getConnection` method to check and potentially replace stale connections.