mysqljs/mysql

Auto-rollback of released connections without transaction commit

Open

#1 116 ouverte le 3 juin 2015

Voir sur GitHub
 (8 commentaires) (0 réactions) (0 assignés)JavaScript (18 137 stars) (2 502 forks)batch import
featurehelp wanted

Description

When using a connection pool, releasing a connection should have a similar effect to ending a connection (aside from simply keeping the connection open). For starters, it would be extremely convenient to know if a connection has started a transaction (i.e. a boolean flag for isInTransaction) which would provide the following benefits:

  1. Passing an existing connection to child functions allows the child functions to operate independently and decide when/whether transactions need to be started (ability to shorten transaction lifecycles to reduce potential deadlocks) vs. managing this in parent code.
  2. If connections are released without making a call to "Connection.commit", they should really auto-rollback the transaction (just like a call to connection.end would do). This ensures that when the connection is re-used, the true effect is that the connection operates like a new connection (rather than having strange side-effects where existing transactions might cause deadlock).

Guide contributeur

Stack technique
javascriptnodejsmysql
Domaine
database
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-2 days
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
Node.jsMySQL protocolconnection poolingtransaction management
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
40
Direction de recherche
Examine the Connection and Pool classes in the mysqljs/mysql repository. The current release() method does not auto rollback uncommitted transactions. Investigate the inTransaction flag and how end() triggers rollback. Review issue comments for any additional context or rejected approaches. Consider adding isInTransaction property and modifying release() to call rollback if a transaction is active. Ensure existing tests pass and add new tests for this behavior.