microsoft/Terminal

Profile reordering for Settings UI

Open

#8 914 ouverte le 27 janv. 2021

Voir sur GitHub
 (43 commentaires) (177 réactions) (1 assigné)C++ (3 212 forks)batch import
Area-SettingsUIHelp WantedIssue-FeatureProduct-Terminal

Métriques du dépôt

Stars
 (35 764 stars)
Métriques de merge PR
 (Merge moyen 27j 19h) (24 PRs mergées en 30 j)

Description

Description of the new feature/enhancement

The Settings UI doesn't have a way of reordering your profiles. In the JSON, we're able to just reorder the array of profiles.list.

Some considerations to keep in mind include:

Ideally, we could have a design that's future-proof. But since we don't know when the above will be implemented, we could just go with a simple non-future-proof design now, then redesign later.

EDIT: We should also consider deprecating hidden once this is in.

Proposed technical implementation details (optional)

A few ideas have come to mind, but @cinnamon-msft and I haven't actually taken the time to sit down and design this yet. I'll list a few ideas here, but I'm excited to see what ideas the community can come up with:

1. Drag and drop NavigationView's menu items

Pretty straightforward. The idea is that you can drag and drop the menu items for profiles.

NavigationView

Concerns:

  • knowing that those menu items are drag-able isn't intuitive. Maybe we could add some kind of gripper icon? gripper icon example
  • not really future-proof
  • TECHNICALLY: I don't believe the items in a nav view can be re-ordered trivially (without implementing a fork of nav view, quite likely).
    • Open question: Can we just stick the list of profiles as a ListView with CanReorder=true inside the NavView?
    • This would almost certainly require a huge refactor of how navigation works in the settings UI

2. Add an index "setting" in Profile > General

This would probably be a number box on each Profile > General page (not base layer).

Concerns:

  • don't like that you can't see all the overall order

Guide contributeur