Missing operator delete/delete[] for some allocated objects · microsoft/Terminal#875

(7 commentaires) (0 réactions) (0 assignés)C++ (3 212 forks)batch import

Area-CodeHealthHelp WantedIssue-BugProduct-Conhost

Métriques du dépôt

Stars: (35 764 stars)
Métriques de merge PR: (Merge moyen 27j 19h) (24 PRs mergées en 30 j)

Description

Hi.

Looks like there are few places in the Terminal code where I can suspect a memory leaks due to missing operator delete or operator delete[]. These allocation sites can be grouped into following:

raw operator new without operator delete like this https://github.com/Microsoft/Terminal/blob/master/src/cascadia/TerminalConnection/ConptyConnection.cpp#L191
allocation by operator new some global object or class member (https://github.com/Microsoft/Terminal/blob/master/src/cascadia/TerminalControl/TermControl.cpp#L281)
allocation by operator new some memory in a function and return it by raw pointer, which can leak then.

Here is my gist with quite a simple grep foroperator new calls - https://gist.github.com/dreamer-dead/c43248466fc4d445378b4dfba80d8d25

Is this an intentional behaviour or a bug that should be fixed?

Guide contributeur

Direction de recherche: Examinez chaque site d'allocation listé dans le gist (par exemple, ConptyConnection.cpp ligne 191, TermControl.cpp ligne 281) et ajoutez les appels manquants à operator delete/delete[]. Envisagez d'utiliser RAII ou des pointeurs intelligents pour éviter les fuites.
Stack technique: cpp
Domaine: backend
Type d'issue: Bug
Difficulté: 3
Temps estimé: 1-3 heures
Statut d'activité: Active
Clarté: Claire
Prérequis: C++Memory Management
Accessibilité débutant: 65

Métriques du dépôt

Description

Guide contributeur

Recevez de nouvelles issues Easy par e-mail.