Support find_package for GTest to avoid redundant downloads
#1 256 ouverte le 27 juil. 2026
Métriques du dépôt
- Stars
- (5 695 étoiles)
- Métriques de merge PR
- (Merge moyen 8j) (1 PR mergée en 30 j)
Description
Description
In tests/CMakeLists.txt, the current logic uses pkg_search_module(GTestMain gtest_main) to detect a pre-installed GTest. If not found, it falls back to downloading GTest source via Git.
However, pkg_search_module relies on pkg-config (.pc files), which is not commonly available or generated by package managers like vcpkg on Windows. vcpkg provides CMake config files (e.g., GTestConfig.cmake) instead, which are meant to be used with find_package().
As a result, even when GTest is already installed via vcpkg, pkg_search_module fails to find it, and the build unnecessarily downloads and compiles GTest from source.
Suggestion
Add find_package(GTest) as an additional detection method before falling back to the download step. For example:
find_package(GTest QUIET)
if (NOT GTest_FOUND)
pkg_search_module(GTestMain gtest_main)
endif()
if (NOT GTest_FOUND AND NOT GTestMain_FOUND)
# Fall back to downloading GTest via Git
...
endif()
This would allow users with GTest installed via vcpkg (or other CMake-config-based package managers) to use their existing installation without redundant downloads.