mariogarridopt/json-viewer

Change app icon on dark mode

Ouverte

#2 ouverte le 21 juil. 2025

 (0 commentaire) (0 réaction) (0 personne assignée)HTML (0 fork)auto 404
enhancementgood first issue

Métriques du dépôt

Stars
 (0 étoile)
Métriques de merge PR
 (Métriques PR en attente)

Description

The current icon for the app is not very well visible on dark mode.

There is a way to change the icon based on the theme of the browser:

   {
     "manifest_version": 3,
     "name": "My Extension",
     "version": "1.0",
     "icons": {
       "16": "icons/icon-light-16.png",
       "48": "icons/icon-light-48.png",
       "128": "icons/icon-light-128.png",
       "16": {
         "theme_light": "icons/icon-light-16.png",
         "theme_dark": "icons/icon-dark-16.png"
       },
       "48": {
         "theme_light": "icons/icon-light-48.png",
         "theme_dark": "icons/icon-dark-48.png"
       },
       "128": {
         "theme_light": "icons/icon-light-128.png",
         "theme_dark": "icons/icon-dark-128.png"
       }
     },
     "permissions": [
       "storage"
     ]
   }

My suggestion is to take the current icon, invert it so that the back and white and add it to the manifest to be used when browser there is dark.

Guide contributeur