lenra-io/lenra_components

Is 'utils' belongs to this library ?

Ouverte

#7 ouverte le 18 août 2021

 (4 commentaires) (0 réaction) (0 personne assignée)Dart (0 fork)auto 404
help wantedinvalidquestion

Métriques du dépôt

Stars
 (4 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

There is a folder 'utils' that give some helpers to :

  • parse a color
  • validate textfield input (password/email)

The color parser is not used by the library. It is just exposed as part of the lib. The validator is partially used by the lenra_text_form_field.dart component to check the value of the input based of the type parameter (email or password).

I think we can safely remove the color parser but i'm not sure about the validator :

  • Is it our job to check the value of the input ? If not, we should remove the validator.
  • If it is our job, we should provide a way for the user to completely override the validator (not just add on top of the existing validator).
  • Should we add more types in the futur ? (phone number, address...)

@lenra-io/lenra any thought ?

Guide contributeur