keystonejs/keystone-classic

Adding `track` or `defaultSort` to any List breaks admin UI

Open

#4 512 ouverte le 14 nov. 2017

Voir sur GitHub
 (3 commentaires) (1 réaction) (0 assignés)JavaScript (14 656 stars) (2 288 forks)batch import
bughelp wanted

Description

Any ideas whatsoever would be great.

Expected behavior

I should be able to instantiate a new List with track or defaultSort set without an issue.

Actual/Current behavior

But for some reason, I get the following error on the /keystone/signin page:

signin.js:978 Uncaught TypeError: $export is not a function
    at Object.76../_descriptors (signin.js:978)
    at s (signin.js:1)
    at signin.js:1
    at Object.15.../../modules/_core (signin.js:83)
    at s (signin.js:1)
    at signin.js:1
    at Object.4.core-js/library/fn/object/define-property (signin.js:19)
    at s (signin.js:1)
    at signin.js:1
    at Object.48../_an-object (signin.js:610)

Steps to reproduce the actual/current behavior

Just add one of the aforementioned options to a List, old or new.

Environment

Software Version
Keystone 4.0.0-beta.7
Node 8.9.1

Babel config:

{
  "presets": [
    ["env", {
      "targets": {
        "node": "current"
      }
    }],
    ["stage-0"]
  ],
  "plugins": [
    "transform-runtime",
    "import-glob"
  ]
}

Guide contributeur

Stack technique
javascriptnodejs
Domaine
full stack
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-2 days
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
JavaScriptKeystone classic basics
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
30
Direction de recherche
Investigate the error '$export is not a function' from core js. This likely indicates a module bundling issue triggered by adding 'track' or 'defaultSort' to a List. Examine the Keystone classic source code for List class initialization and how these options are processed. Also check the admin UI build configuration (babel and webpack) to see if the options cause a discrepancy in module imports. The issue is from 2017 and has few comments, so no clear resolution yet. Reproduction may require setting up a Keystone project with those options and debugging the client side bundle.