keystonejs/keystone-classic

Make less files not publicly available

Open

#1 639 ouverte le 2 sept. 2015

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)JavaScript (14 656 stars) (2 288 forks)batch import
bughelp wanted

Description

Every file under /public/styles/ is available through http when keystone is running.

Since *.less files could be considered as a part of the source code, could we move them to another location, e.g. /templates/styles/ to protect them from being available publicly?

It may be a good idea to keep /public/ folder only for files that are required during runtime, and keep source files elsewhere.

Guide contributeur

Stack technique
javascriptnodejscss
Domaine
securitybackend
Type d'issue
security
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Keystone file structureLess CSSNode.js static serving
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
65
Direction de recherche
Investigate the current file structure under /public/styles/ and /templates/ to understand how Keystone serves static assets. Identify all references to style files in the application (e.g., in templates, layout files, or server configuration) that would need updating after the move. Check if there are any existing mechanisms to prevent public access to certain file types, and consider if a more general solution (like a .htaccess or middleware) is preferred. Review any comments on the issue for maintainer guidance on the desired approach.