keithamus/jwerty

jwerty.is() not working in FF

Open

#38 ouverte le 10 juil. 2013

Voir sur GitHub
 (0 commentaires) (0 réactions) (0 assignés)JavaScript (117 forks)batch import
help wanted

Métriques du dépôt

Stars
 (1 214 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

// For each property in the jwertyCode object, compare to `event`
for (var p in jwertyCode[n]) {
    // ...except for jwertyCode.jwertyCombo...
    if (p !== 'jwertyCombo' && event[p] != jwertyCode[n][p]) returnValue = false;
}

I'm trying to check for key binding when clicking on an element but jwerty.is() does return false for 'shift', 'cmd' & 'alt'. After some minutes of debugging I've found the problem: You're getting the originalEvent which is in that case [object MouseEvent] and has no property keyCode for that reason. Therefore the result is always false. I'm not sure if there is a solution for this problem in FF, but it is working fine in Chrome. Thanks for this wonderful library!

Guide contributeur