karma-runner/karma

script-launcher : bad script browser recognition

Open

#754 ouverte le 23 sept. 2013

Voir sur GitHub
 (2 commentaires) (0 réactions) (0 assignés)JavaScript (1 703 forks)batch import
help wantedtype: backlogtype: feature

Métriques du dépôt

Stars
 (11 918 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

Hi all, just wanted to note that after updating to latest karma (0.10.2) , if someone's got problem with "script browsers" ( we use a .bat to run IE tester with specific IE versions) , it could be because of the "browser type recognition". It gets recognized as "script browser" only if it's path it's absolute

lib\launcher.js line 19

 // TODO(vojta): determine script from name
      if (name.indexOf('/') !== -1) {
        name = 'Script';
      }

we just put a temporary work-around like this

 // TODO(vojta): determine script from name
      if (name.indexOf('/') !== -1  || name.indexOf('.bat') !== -1) {
        name = 'Script';
      }

Guide contributeur