[Refactor]: [ACI] reuse utility functions from connector utils · juspay/hyperswitch#7927

2025-04-29T08:56:26.000Z

### Refactor Description - In Hyperswitch, reusable and connector-agnostic functions used in connector integrations are added to crates/hyperswitch_connectors/src/utils.rs. However, parts of the current ACI integration reimplement these functions instead of reusing them. ### Possible Implementation 1. Review transformer.rs in the ACI connector to identify opportunities to reuse functions from `crates/hyperswitch_connectors/src/utils.rs` . 2. Replace the existing implementations with the corresponding reusable functions from the utils module where applicable. ### Example Current - `shopper_result_url: item.router_data.request.router_return_url.clone(),` Expected - `shopper_result_url: item.router_data.request.get_router_return_url().ok(),` ### Have you spent some time checking if this feature request has been raised before? - [ ] I checked and didn't find a similar issue ### Have you read the Contributing Guidelines? - [x] I have read the [Contributing Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md) ### Are you willing to submit a PR? None

(3 commentaires) (0 réactions) (1 assigné)Rust (4 676 forks)batch import

A-connector-integrationC-refactorE-easygood first issue

Métriques du dépôt

Stars: (42 690 stars)
Métriques de merge PR: (Merge moyen 8j 12h) (212 PRs mergées en 30 j)

Description

Refactor Description

In Hyperswitch, reusable and connector-agnostic functions used in connector integrations are added to crates/hyperswitch_connectors/src/utils.rs.

However, parts of the current ACI integration reimplement these functions instead of reusing them.

Possible Implementation

Review transformer.rs in the ACI connector to identify opportunities to reuse functions from crates/hyperswitch_connectors/src/utils.rs .
Replace the existing implementations with the corresponding reusable functions from the utils module where applicable.

Example

Current - shopper_result_url: item.router_data.request.router_return_url.clone(), Expected - shopper_result_url: item.router_data.request.get_router_return_url().ok(),

Have you spent some time checking if this feature request has been raised before?

I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

I have read the Contributing Guidelines

Are you willing to submit a PR?

None

Guide contributeur

Direction de recherche: Examinez le fichier transformer.rs du connecteur ACI dans le dépôt Hyperswitch. Identifiez les endroits où les fonctions utilitaires de crates/hyperswitch connectors/src/utils.rs sont dupliquées ou peuvent remplacer le code existant, puis remplacez les.
Stack technique: rust
Domaine: backendapipayments
Type d'issue: Refactorisation
Difficulté: 3
Temps estimé: Une demi journée
Statut d'activité: Active
Clarté: Claire
Prérequis: RustFamiliarity with Hyperswitch codebaseUnderstanding of connector integration pattern
Accessibilité débutant: 65