jsx-eslint/eslint-plugin-react

no-unstable-nested-components does not detect components starting with underscore

Open

#4 002 ouverte le 28 avr. 2026

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)JavaScript (8 630 stars) (2 797 forks)batch import
bughelp wanted

Description

A pattern we use commonly in our codebase (pre-dates me, and we're too far along the road now to change) is to prefix some components with an underscore e.g. when forwarding refs, or to signal a component shouldn't be exported etc.

Components with this naming convention do not get detected as parent components, and thus the unstable nested components are not flagged

function _Parent() {
  function NotFlagged() {
    return <b>oh no</b>
  }

  return <NotFlagged />
}

Given there have been other issues raised relating, and carve outs added for, this naming convention:

I think this constitutes a bug/oversight in this rule. Happy to make a PR, if there is agreement

Guide contributeur

Stack technique
javascriptreact
Domaine
frontenddeveloper experience
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
basic JavaScriptReact component naming conventions
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
70
Direction de recherche
Locate the rule implementation in the plugin's source code, likely in `lib/rules/no unstable nested components.js`. Review the logic that detects parent components; it likely uses a naming pattern like `/^[A Z]/` or similar. Update the regex or check to also include components starting with underscore (e.g., `/^[ A Z]/`). Ensure the fix aligns with existing carve outs for underscore in other rules, referenced in issues #3560 and #2603. Test with the provided example to confirm the rule flags the nested component.