jsx-eslint/eslint-plugin-react

[Bug]: react/jsx-no-leaked-render reports error on boolean values and tries to convert them

Open

#3 908 ouverte le 21 mars 2025

Voir sur GitHub
 (2 commentaires) (5 réactions) (0 assignés)JavaScript (8 630 stars) (2 797 forks)batch import
enhancementhelp wantedtypescript

Description

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

Using following setup:

'react/jsx-no-leaked-render': ['error', { validStrategies: ['ternary', 'coerce'] }]

Image

The code reports error even though emptyCollection is already boolean value. I understand that the plugin does not take into account actual types that TS provides.

Running lint command reports an issue unless I convert the code to this 👇

Image

Is there a way to prevent this from being "fixed" since it's already a boolean value?

Expected Behavior

eslint-plugin-react version

v7.37.4

eslint version

v9.18.0

node version

v22.13.0

Guide contributeur

Stack technique
javascriptreact
Domaine
frontendtooling
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-2 days
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
ESLint plugin developmentReact JSXAST understanding
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
60
Direction de recherche
Examine the rule implementation at `lib/rules/jsx no leaked render.js`. Review the test file for this rule (likely `tests/lib/rules/jsx no leaked render.js`) to understand current test cases. The core issue is that the rule incorrectly flags boolean variables when using the ternary or coerce strategy. Determine if the rule should rely on TypeScript type annotations (using `@typescript eslint/parser`) or if a simpler heuristic (e.g., checking that the expression is a boolean literal or `typeof x === 'boolean'`) can be applied. Check the comments in issue #3908 for any maintainer suggestions.