jsx-eslint/eslint-plugin-react

[Bug]: `hook-use-state` suggested fix should update all reference

Open

#3 810 ouverte le 31 août 2024

Voir sur GitHub
 (2 commentaires) (0 réactions) (0 assignés)JavaScript (8 630 stars) (2 797 forks)batch import
enhancementhelp wanted

Description

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

The current fix suggested is to simply replace the variable, This isn't smart enough

It should update all references

https://github.com/user-attachments/assets/92187480-3b65-4667-a94b-66c8670de283

Expected Behavior

This is a custom react-hook-use-state rule I wrote. Before this, I didn’t know the existence of react/hook-use-state

it's smart enough

https://github.com/user-attachments/assets/196c5324-b1f8-41d7-8f5a-efd2c8342508

I have implemented almost all the functions of react/hook-use-state, but the logic is simpler

I checked the source code of hook-use-state, it is very complicated, and I can't modify it

I hope react/hook-use-state can also achieve this function by someone

eslint-plugin-react version

v7.35.0

eslint version

v9.9.1

node version

v20

Guide contributeur

Stack technique
javascriptreact
Domaine
frontendtooling
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
4
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
over 1 week
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
ESLint rule developmentASTReact hooks
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
25
Direction de recherche
Investigate the source code of the `react/hook use state` rule in `lib/rules/hook use state.js`. Understand the current fix mechanism and why it does not update all references. Compare with similar rules that handle multiple references. The goal is to modify the fix function to traverse all usages of the variable and apply the rename everywhere. Also review the rule's test file to understand expected behavior.