jsx-eslint/eslint-plugin-react

[Bug]: `react/jsx-newline` does not remove empty lines for surrounding tags

Open

#3 663 ouverte le 6 déc. 2023

Voir sur GitHub
 (2 commentaires) (0 réactions) (0 assignés)JavaScript (8 630 stars) (2 797 forks)batch import
enhancementhelp wanted

Description

Is there an existing issue for this?

  • I have searched the existing issues and my issue is unique
  • My issue appears in the command-line and not only in the text editor

Description Overview

react/jsx-newline with { "prevent": true } does not remove empty lines for surrounding tags.

Currently react/jsx-newline does not detect any lint errors for the following JSX:

<div>

  <span>
    hi
  </span>

</div>

Expected Behavior

The current detection feels like unintended behavior, as I would expect all newlines within JSX to be removed as follows:

<div>
  <span>
    hi
  </span>
</div>

If there is a different eslint rule that checks for this please let me know!

eslint-plugin-react version

v7.33.2

eslint version

v8.55.0

node version

v18.6.0

Guide contributeur

Stack technique
javascriptreact
Domaine
frontendtooling
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
ESLint rule developmentAST traversalJavaScript
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
65
Direction de recherche
Examine the rule implementation in `src/rules/jsx newline.js`. The current logic detects newlines within JSX elements but not empty lines between a parent tag and its children (e.g., surrounding tags). Check the `create` method and how it uses `context.getSourceCode().getText()` or similar to find newlines. Look at the test file `tests/lib/rules/jsx newline.js` for existing tests to understand expected behavior. The fix likely involves adding a check for newlines between the opening tag and the first child, and between the last child and closing tag.