jsx-eslint/eslint-plugin-react

[jsx-key]: report on `yield`

Open

#352 ouverte le 7 déc. 2015

Voir sur GitHub
 (2 commentaires) (1 réaction) (0 assignés)JavaScript (2 797 forks)batch import
enhancementhelp wantedrule

Métriques du dépôt

Stars
 (8 630 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

Seems like yield <Component x={y}/> should be reported by jsx-key if there is no key prop.

This is valid:

for (let [idx, datum] of data.entries()) {
  yield (<MyComponent datum={datum} key={idx} />)
}

This is reported:

for (let [idx, datum] of data.entries()) {
  yield (<MyComponent datum={datum} />) // msg: need `key` prop
}

I can knock this out, if it makes sense.

(cc #332 as it will likely conflict with this if completed concurrently.)

Guide contributeur