jsx-eslint/eslint-plugin-react

prop-types Validating external propTypes (eg. decorators)

Open

#322 ouverte le 19 nov. 2015

Voir sur GitHub
 (13 commentaires) (7 réactions) (0 assignés)JavaScript (8 630 stars) (2 797 forks)batch import
enhancementhelp wantedrule

Description

This is something that comes from loggur/react-redux-provide#1 as propTypes are used to actually define data that will be provided to the component like this:

@provide({
  list: PropTypes.arrayOf(PropTypes.object).isRequired,
  pushItem: PropTypes.func.isRequired
})
export default class GoodTimes extends Component {
}

That doesn't coop well with this rule unfortunately. I am wondering if there is a way how to analyze this and read propTypes from higher-order component / decorator also.

I have noticed some undocumented customValidators, but I am not sure how does that works. If I understand correctly it accepts list of props that will be ignored?

Guide contributeur

Stack technique
javascriptreact
Domaine
toolingdeveloper experience
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
3-5 days
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
Understanding of ESLint plugin architectureFamiliarity with React propTypesKnowledge of decorators syntaxExperience parsing AST with ESLint
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
30
Direction de recherche
Investigate the current prop types rule implementation in eslint plugin react, specifically how it validates PropTypes on class components and how decorators are handled by ESLint's parser. Look at the linked issue loggur/react redux provide#1 for context. Check if there are any existing discussions or attempted PRs. Consider using AST selectors to detect PropTypes defined in decorators and integrate them into the validation logic.