jsx-eslint/eslint-plugin-react
Voir sur GitHubRule Proposal: Check for global references inside `render`
Open
#246 ouverte le 13 oct. 2015
acceptedhelp wantednew rule
Métriques du dépôt
- Stars
- (8 630 stars)
- Métriques de merge PR
- (Aucune PR mergée en 30 j)
Description
When using React for server rendering, it can be problematic when a component relies on window or document or other globals inside of render. It will cause checksum issues when you get to the client. Instead of checking whether you are on the client within render, it's better to use the componentDidMount lifecycle event to set a state which is used in render instead.
Problematic:
class Foo extends React.Component {
render() {
if (typeof window === 'undefined') {
return null;
}
return <Bar />;
}
}
Better:
class Foo extends React.Component {
constructor() {
this.state = {showBar: false};
}
componentDidMount() {
this.setState({showBar: true});
}
render() {
if (!this.state.showBar) {
return null;
}
return <Bar />;
}
}