joshwnj/react-visibility-sensor

Evaluate IntersectionObserver support

Open

#56 ouverte le 16 déc. 2016

Voir sur GitHub
 (3 commentaires) (0 réactions) (0 assignés)JavaScript (2 300 stars) (198 forks)batch import
enhancementhelp wanted

Description

Suggested by @Andarist in https://github.com/joshwnj/react-visibility-sensor/pull/54#issuecomment-267279074

What would you say about implementing IntersectionObserver support? It could even be the default with scroll and interval being used only as a fallback settings. Its already implemented in 2 browsers.

https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API

It would be cool to try this, and compare to the current approach. We can try the polyfill for browsers that don't support it yet:

https://github.com/WICG/IntersectionObserver/tree/gh-pages/polyfill

http://caniuse.com/#search=Intersection

Guide contributeur

Stack technique
reactjavascript
Domaine
frontendperformance
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
React knowledgeIntersectionObserver APIPolyfill understanding
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
50
Direction de recherche
This issue involves implementing IntersectionObserver support in the react visibility sensor component. The idea was suggested in PR #54 (linked). To start, review the current component source code (likely in src/index.js or similar) and understand how it currently uses scroll/interval events. Then implement an IntersectionObserver based approach as the default, with scroll/interval fallback for unsupported browsers. The polyfill from WICG can be used for older browsers. Test the changes and compare performance with the current approach. Check the caniuse link for browser support. There is no linked PR, so this is open for contribution.