josdejong/mathjs

Easier types when working with "create"

Open

#2 322 ouverte le 21 sept. 2021

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)JavaScript (1 298 forks)batch import
bughelp wantedtypescript

Métriques du dépôt

Stars
 (13 832 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

I followed the custom bundling docs and created my own instance of math.js, like this:

const math = create({ addDependencies, bignumberDependencies, divideDependencies, meanDependencies }, config);
const mbn = this.math.bignumber!;

What I don't like is that I have to use the ! non-null assertion operator, even if it is clear that the bignumber property should be non-null (as per the bignumberDependencies object passed to create).

I further had to disable the @typescript-eslint/no-non-null-assertion ESLint rule, because the lint task was failing.

My feature request: let the compiler know that the objects returned by create are non-null, based on the inputs provided.

Guide contributeur