jantimon/favicons-webpack-plugin

Make sure examples work

Open

#295 ouverte le 9 janv. 2022

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)JavaScript (226 forks)batch import
help wantedwontfix

Métriques du dépôt

Stars
 (1 198 stars)
Métriques de merge PR
 (Merge moyen 8h 36m) (3 PRs mergées en 30 j)

Description

Is your feature request related to a problem? Please describe. I downloaded the repo, installed Node.js v10.20.0, and installed dependencies. Then I went to the basic example and ran pnpx webpack serve, and it resulted in an error (probably because there is an old version of webpack-dev-server?).

Describe the solution you'd like The examples should include dependencies like webpack, webpack-cli, and webpack-dev-server, and have scripts in package.json for starting server and building. They should also work with any node version >= the minimum node version.

Describe alternatives you've considered Using the favicon option in HtmlWebpackPlugin.

Additional context I'm using nodist and pnpm on Windows 10.

Guide contributeur