iodide-project/iodide
Voir sur GitHubvalidate _all_ API args, break out API arg validation in #1703 into a little library that we can use to
Open
#1 760 ouverte le 22 avr. 2019
good first issue
Métriques du dépôt
- Stars
- (1 483 stars)
- Métriques de merge PR
- (Aucune PR mergée en 30 j)
Description
following from @hamilton's nice file API argument validation in #1703, we should apply argument validation to all of the iodide API. in the process, we should break the argument validation into proptypes-style helper function
see: https://github.com/iodide-project/iodide/pull/1703#discussion_r274200088
export function loadFile(fileName, fetchType, variableName = undefined) {
argType.validate({
fileName: [fileName, argType.string],
fetchType: [fetchType, argType.enum(FETCH_RETURN_TYPES)],
variableName: [variableName, argType.string.optional]
})
return sendFileRequestToEditor(fileName, "LOAD_FILE", {
fetchType
}).request.then(handleResourceLoad(fetchType, variableName));
}