internetarchive/openlibrary

Footer external links should open in a new tab

Fermée

#13 057 ouverte le 29 juin 2026

 (3 commentaires) (0 réaction) (0 personne assignée)Python (1 961 forks)batch import
Good First IssueLead: @mekarpelesNeeds: LeadNeeds: ResponseNeeds: TriagePriority: 4Type: Bug

Métriques du dépôt

Stars
 (6 616 étoiles)
Métriques de merge PR
 (Merge moyen 6j 2h) (126 PRs mergées en 30 j)

Description

Problem

All external links in the footer open in the same tab instead of a new tab.

https://github.com/user-attachments/assets/67843849-e04c-4cdb-ab85-7be337966488

Affected file: openlibrary/templates/lib/nav_foot.html

Affected links:

  • Bluesky, X (Twitter), GitHub social icons
  • Careers (archive.org)
  • Blog (blog.openlibrary.org)
  • Terms of Service (archive.org)
  • Donate (archive.org)
  • Writing Bots (docs.openlibrary.org)
  • Release Notes (github.com)

Reproducing the bug

  1. Go to https://openlibrary.org
  2. Scroll down to the footer
  3. Click any external link (e.g. Bluesky, GitHub, Blog, Careers)
  • Expected behavior: External links should open in a new tab (target="_blank" rel="noopener noreferrer")
  • Actual behavior: External links open in the same tab, navigating the user away from Open Library

Context

  • Browser : Chrome
  • OS : Mac
  • Logged in (Y/N): Y
  • Environment : prod

Breakdown

All external links in the footer open in the same tab instead of a new tab.

https://openlibrary.org (scroll to footer)

Affected file: openlibrary/templates/lib/nav_foot.html

Affected links:

  • Bluesky, X (Twitter), GitHub social icons
  • Careers (archive.org)
  • Blog (blog.openlibrary.org)
  • Terms of Service (archive.org)
  • Donate (archive.org)
  • Writing Bots (docs.openlibrary.org)
  • Release Notes (github.com)
  1. Go to https://openlibrary.org
  2. Scroll down to the footer
  3. Click any external link (e.g. Bluesky, GitHub, Blog, Careers)
  • Expected behavior: External links should open in a new tab (target="_blank" rel="noopener noreferrer")
  • Actual behavior: External links open in the same tab, navigating the user away from Open Library

Overview

Add target="_blank" rel="noopener noreferrer" to all external anchor tags in the footer template.

Requirements Checklist

  • Add target="_blank" rel="noopener noreferrer" to all external links in nav_foot.html

Related files

  • openlibrary/templates/lib/nav_foot.html

Stakeholders

Guide contributeur