Cancel gracefully when connecting to kafka broker
#12 214 ouverte le 9 nov. 2022
Métriques du dépôt
- Stars
- (9 892 stars)
- Métriques de merge PR
- (Merge moyen 2j 12h) (136 PRs mergées en 30 j)
Description
If the user sends a signal to telegraf while kafka_consumer is connecting to the broker (before sarama.NewConsumerGroup() has returned), the signal will be delayed until connection is made or timed out. This means sigint to shut down telegraf, or sighup to reload config are ignored while connecting to the broker.
Since #12111, telegraf allows the kafka connection to be deferred until after startup and to retry for a very long time in case the broker is down. This means the time spent connecting to the broker can be much larger and signals can be blocked indefinitely.
It doesn't look like there is a way to cancel sarama.NewConsumerGroup(). We need to find out if there is a different way to connect that has a way to cancel, or work with upstream to add one.