infinitered/ignite

Dark mode support in splash-screen generator

Open

#2 855 ouverte le 25 nov. 2024

Voir sur GitHub
 (3 commentaires) (0 réactions) (2 assignés)TypeScript (16 168 stars) (1 342 forks)batch import
enhancementhelp wanted

Description

I'd like to be able to generate the assets for a dark mode splash screen along side the "normal" light mode assets.

Currently, I can call npx ignite-cli generate splash-screen and the generator will read logo.png from ignite/templates/splash-screen and output the necessary assets to assets/images. That will work whether logo.png is the image I want to use for light mode or dark mode. The trouble is that if I do one it will overwrite the other and vice versa. I'd like to be able to generate both sets of assets at the same time so I can reference them from my expo app.json

I suggest adding a --dark parameter that would tell the generate to read logo-dark.png, output assets that start with "splash-logo-dark" instead of "splash-logo," and update app.json accordingly. But there might be other possible solutions.

I'm happy to take a shot at adding this myself and sending a PR. But I thought it would be wise to make sure something like this wasn't already in the works. And that the solution I suggested above is a valid design.

Thanks!

Guide contributeur

Stack technique
typescriptreact nativenodejs
Domaine
mobilecli
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
blocked
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Basic knowledge of React NativeFamiliarity with Ignite CLIUnderstanding of splash screen asset generation
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
55
Direction de recherche
The user suggests adding a dark flag to the generate splash screen command. Investigate the current implementation in ignite/templates/splash screen and the corresponding CLI command in the Ignite repository. Review how the generator reads logo.png and outputs assets. Then, consider modifying the command to accept dark, read logo dark.png, and output assets with 'splash logo dark' prefix while updating app.json. Check comments on the issue for any additional requirements or designs.