hyperstack-org/hyperstack

webpacker integration does not pull in .css packs

Open

#266 ouverte le 7 oct. 2019

Voir sur GitHub
 (0 commentaires) (0 réactions) (0 assignés)JavaScript (531 stars) (43 forks)batch import
bughelp wanted

Description

If you require css files in the client_only and client_and_server pack files, they do not get included in the required assets.

Not sure if this is practical or possible. Currently hyper-config pulls in the pack file by doing an opal require on them. But if you try to require a css file it doesnt' like it.

The work around is to add one or both these lines to the layouts, if you are requiring css assets in the pack files: <%= stylesheet_pack_tag 'client_only' %>
If you are requiring css libraries in the client_only.js pack file
and
<%= stylesheet_pack_tag 'client_and_server' %>
If you are requiring css libraries in the client_and_server.js pack file

Guide contributeur

Stack technique
rubyrailsjavascriptcss
Domaine
frontendbuild system
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
Ruby on Railswebpackerhyperstack basics
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
25
Direction de recherche
Investigate how hyperstack's hyper config processes pack files and why .css files are skipped. Look at the code that requires pack files in the Ruby gem. Consider modifying the require logic to include CSS assets or adding a webpacker configuration to handle stylesheet pack tags. The workaround suggests adding stylesheet pack tag manually in layouts, so the goal is to automate this.