guardicore/monkey

Invalid configurations can be exported in the UI

Open

#3 703 ouverte le 15 sept. 2023

Voir sur GitHub
 (0 commentaires) (0 réactions) (0 assignés)Python (6 250 stars) (752 forks)batch import
BugComplexity: MediumHelp wantedImpact: LowUI

Description

Describe the bug

While an invalid configuration can't be submitted through the UI, it can be exported.

Trying to import that configuration in the UI isn't allowed, so it could be frustrating for a user who didn't realise that some values were invalid while exporting.

To Reproduce

Steps to reproduce the behavior:

  1. Run Island
  2. Add invalid configuration value somewhere
  3. Try submitting and see warning box
  4. Export and check the exported configuration for invalid value

Expected behavior

Don't allow exporting configuration if some values are invalid.

Screenshots

  1. Added invalid IP to configuration image

  2. Export modal works normally, but a warning is shown on the configuration page image

  3. Warning box image

  4. Exported configuration image

Guide contributeur

Stack technique
python
Domaine
apibackend
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
under 1 hour
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Aucun
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
85
Direction de recherche
Investigate the configuration export endpoint in the backend (likely in a Python file handling configuration). Check if there is existing validation logic used during configuration submission and apply it before export. Look at the UI export component to understand the flow. The warning box suggests validation already exists; ensure it's triggered on export as well.