graphql-python/graphene-sqlalchemy

Integrating support for graphene-sqlalchemy-filter into code base

Open

#335 ouverte le 29 mars 2022

Voir sur GitHub
 (10 commentaires) (0 réactions) (4 assignés)Python (939 stars) (222 forks)batch import
enhancementhelp wanted

Description

As there is limited filtering with graphene-sqlalchemy, I have been using graphene-sqlalchemy-filter which has many stock filters included. Unfortunately the developer seems to have lost interest in the code base and a critical PR to add support for Graphene 3.0 has been unmerged for six months.

I have tried contacting the developer a few times without response.

As the filtering code for the add-on is contained in the graphene-sqlalchemy-filter package's two files, I propose merging this code into graphene-sqlalchemy.

Would this be OK?

Guide contributeur

Stack technique
pythongraphqlsql
Domaine
backendapi
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-2 days
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
graphene sqlalchemygraphene sqlalchemy filterGraphene 3.0SQLAlchemy filtering
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
30
Direction de recherche
Review the unmerged PR at art1415926535/graphene sqlalchemy filter#63 for Graphene 3.0 support. Examine the two filter files in that package. Understand the current filtering implementation in graphene sqlalchemy. Discuss with maintainers on the issue to confirm scope and integration approach.