grafana/loki

Replace `go.uber.go/atomic` with Go standard library `sync/atomic`

Open

#20 673 ouverte le 4 févr. 2026

Voir sur GitHub
 (3 commentaires) (0 réactions) (0 assignés)Go (28 187 stars) (3 997 forks)batch import
good first issue

Description

Summary

We currently have a linter rule that blocks usage of sync/atomic and forces us to use go.uber.go/atomic instead. This rule was originally added because sync/atomic required atomic operations on primitive types, which was considered error-prone.

However, since Go 1.19, the standard library sync/atomic package now includes typed wrappers (e.g., atomic.Uint32, atomic.Int64, atomic.Bool, etc.) that provide the same safety guarantees as go.uber.go/atomic. This makes the uber package redundant.

Context

Prometheus is also making this transition:

Proposed Changes

  1. Remove the linter rule that blocks sync/atomic
  2. Migrate all go.uber.go/atomic usage to the standard library sync/atomic typed wrappers
  3. Configure a linter rule to block the old-style atomic functions that operate on primitive types (e.g., atomic.AddInt64, atomic.LoadUint32) to ensure we only use the new typed wrappers and avoid accidental misuse

This approach gives us:

  • Fewer external dependencies
  • Alignment with the broader Go ecosystem
  • Same safety guarantees we had with uber/atomic

References

Guide contributeur

Stack technique
go
Domaine
backenddeveloper experience
Type d'issue
refactor
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-2 days
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
active
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Go 1.19+ knowledgeUnderstanding of atomic operationsFamiliarity with linter configurationBasic Git workflow
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
60
Direction de recherche
Start by examining the Go linter configuration file (likely `.golangci.yml` or similar) to remove the rule blocking `sync/atomic`. Then search the entire codebase for imports of `go.uber.org/atomic` and replace them with the equivalent `sync/atomic` typed wrappers (e.g., `atomic.Uint32`, `atomic.Int64`). Refer to the linked Prometheus PR (https://github.com/prometheus/prometheus/pull/18009) for an example of the transition. Ensure that the changes compile and pass tests.