cmd/vet: warn about unused struct or array, ignoring assignment to field or element · golang/go#449

2009-12-22T02:14:21.000Z

by **RyanneDolan**: What steps will reproduce the problem? v := new(struct{i int}) v.i = 1 What is the expected output? What do you see instead? Should get "v declared and not used" error. Instead, compiles fine. What is your $GOOS? $GOARCH? linux/386 Which revision are you using? (hg identify) 54392bd03d06 tip Please provide any additional information below. The dot operator should mark its left operand as "used" only when it appears on the RHS. a = 1 // 'a' is not marked as used (CORRECT) v.i = 1 // 'v' is marked as used (WRONG) a = v.i // 'v' is marked as used (CORRECT) This bug is important to fix for consistency, and because it confuses new programmers who might expect reference semantics: for _,v := range arr {v.i = 1} // doesn't do anything Mentioned here: http://groups.google.com/group/golang- nuts/browse_thread/thread/342fe61c78916496/fbb57f693f1aca72

(9 commentaires) (0 réactions) (0 assignés)Go (19 008 forks)batch import

AnalysisNeedsFixhelp wanted

Métriques du dépôt

Stars: (133 883 stars)
Métriques de merge PR: (Aucune PR mergée en 30 j)

Description

by RyanneDolan:

Guide contributeur

Direction de recherche: Inspectez le code de l'outil cmd/vet pour trouver où les affectations aux champs de structure ou aux éléments de tableau marquent l'opérande gauche comme utilisé et modifiez le pour ne le marquer que lorsque l'expression apparaît sur le côté droit.
Stack technique: go
Domaine: backend
Type d'issue: Bug
Difficulté: 2
Temps estimé: 1-3 heures
Statut d'activité: Active
Clarté: Claire
Prérequis: Go
Accessibilité débutant: 60

Métriques du dépôt

Description

Guide contributeur

Recevez de nouvelles issues Easy par e-mail.