testing: complain loudly during concurrent use of T.FatalX and T.SkipX
#15 758 ouverte le 19 mai 2016
Métriques du dépôt
- Stars
- (133 883 stars)
- Métriques de merge PR
- (Aucune PR mergée en 30 j)
Description
The testing package is explicit about the following:
A test ends when its Test function returns or calls any of the methods FailNow, Fatal, Fatalf, SkipNow, Skip, or Skipf. Those methods, as well as the Parallel method, must be called only from the goroutine running the Test function.
However, this is easy to overlook and it is not immediately obvious that the code below is a bad test:
func TestFoo(t *testing.T) {
go func() {
t.Fatal("fatal") // Called from outside the Test function
}()
time.Sleep(1 * time.Second)
}
This currently outputs (what a user expects):
--- FAIL: TestFoo (1.00s)
foo_test.go:10: fatal
However, since t.Fatal is not safe to call outside of the Test function, this is poor feedback since it makes the user think that the test is correctly written when it is actually racy. Instead it should complain loudly that this is wrong.
As I'm debugging poor tests, I've noticed that the calling of t.Fatal in a goroutine is actually a fairly common phenomenon.
Related: #15674
/cc @mpvl @bradfitz