ggml-org/whisper.cpp

max-len as a range or 'suggestion' to reduce dangling tokens

Open

#543 ouverte le 27 févr. 2023

Voir sur GitHub
 (1 commentaire) (2 réactions) (0 assignés)C++ (49 693 stars) (5 535 forks)batch import
enhancementgood first issue

Description

suggestion that the max-len argument allow for some ambiguity of +- words/tokens or a nargs range instead of a hard int, so that the output files don't dangle a single word/token on successive timestamps.

Ex: Given the following output, it would probably be preferrable that the 2nd and 5th timestamp (there/job) would appear with the previous timestamp, possibly hard-wrapped to a second line in the cue, rather than alone.

` [00:06:23.160 --> 00:06:27.000] The other district where Pat was over

[00:06:27.000 --> 00:06:27.000] there,

[00:06:27.000 --> 00:06:28.380] also they know her.

[00:06:28.380 --> 00:06:31.680] So I think they were doing a very good

[00:06:31.680 --> 00:06:32.400] job.

[00:06:32.400 --> 00:06:35.750] - So only those two candidates were the

[00:06:35.750 --> 00:06:36.160] only ones `

Guide contributeur

Stack technique
cpp
Domaine
backendcli
Type d'issue
feature
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
Familiarity with C++Understanding of whisper.cpp command line parsing
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
60
Direction de recherche
First, examine how the max len argument is currently parsed and applied in main.cpp. The issue suggests allowing a range or tolerance (e.g., an integer with a +/ value). Look at the argument parsing code, likely using argparse or similar. Then, modify the logic to accept a range and adjust the output formatting to avoid dangling single words. The comment in the issue provides example output showing the problem; use that to test the change.