ggml-org/whisper.cpp

Streaming to file leads to "duplicates"

Ouverte

#1 056 ouverte le 27 juin 2023

 (3 commentaires) (0 réaction) (0 personne assignée)C++ (6 074 forks)batch import
enhancementgood first issue

Métriques du dépôt

Stars
 (52 968 étoiles)
Métriques de merge PR
 (Merge moyen 5j 20h) (36 PRs mergées en 30 j)

Description

Hi all,

First of all, amazing work on this project. I'm really excited about what you're doing.

There's something I noticed about the way the ./stream works with the file parameter. I believe that for the stdout, it's only printing to a newline every n_new_line, and it would otherwise use a carriage return to overwrite the last line. This works nicely for stdout, but with the file output parameter, it's printed as a new line for every iteration.

I think this is buggy because the resulting text file has a bunch of duplicate lines most of the time, and it's difficult to parse out later. I'm guessing that this was written this way because you can't write carriage returns to a file and have it clear the last line like you can with stdout, but I think it would be a good compromise to only write to file on every n_new_line.

What do you think?

Guide contributeur