facebookarchive/draft-js

Draft breaks when pressing enter on atomic block

Open

#1 191 ouverte le 4 mai 2017

Voir sur GitHub
 (4 commentaires) (8 réactions) (0 assignés)JavaScript (22 554 stars) (2 646 forks)batch import
documentationgood first issue

Description

Do you want to request a feature or report a bug? BUG

What is the current behavior? When the Image is not 100% wide in the editor and you focus cursor after it and press enter you get.

invariant.js:44 Uncaught Invariant Violation: Unknown DraftEntity key.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/stopachka/m6z0xn4r/.

In Media example remove the width styles like showed below. https://github.com/facebook/draft-js/compare/master...leniartek:patch-1 Than place the cursor after image and press enter. image

What is the expected behavior?

Enter to create a empty new line after image.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

all draft versions all browsers

Guide contributeur

Stack technique
javascriptreact
Domaine
frontend
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Basic knowledge of Draft.jsReact experience
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
30
Direction de recherche
The bug occurs when pressing Enter after an atomic block (e.g., image) that is not 100% wide, causing an 'Unknown DraftEntity key' invariant. The issue includes a jsfiddle and a patch (https://github.com/facebook/draft js/compare/master...leniartek:patch 1) that removes width styles to reproduce. To fix, investigate how Draft.js handles atomic blocks on Enter key press, particularly the removal of the entity key. The repository is archived, so any fix would need to be submitted to a fork.