If a `name_mapper` points to a non-existent file, it should tell user that the mapped path doesn't exist (instead of the original path) · facebook/flow#7427

(5 commentaires) (0 réactions) (0 assignés)Rust (1 885 forks)batch import

enhancementerror messagesgood first issuemodule resolution

Métriques du dépôt

module.name_mapper='.*\.css$' -> '<PROJECT_ROOT>/css-modules-stub.js.flow'

import foo from `foo.css`

Flow version: 0.91.

Error should say:

Cannot find module 'foo.css' (after it was remapped to '<PROJECT_ROOT>/css-modules-stub.js.flow', check your .flowconfig mapper paths exist)

Cannot find module 'foo.css'

Another example:

module.name_mapper='debug' -> 'empty/object'

If empty/object doesn't exist, there is no message to say that is the cause of Cannot resolve module 'debug' error.

There are many cases where name_mapper breaks things by the user wouldn't know. Try this to show the errors that are generated:

module.name_mapper='.*' -> '<PROJECT_ROOT>/some-empty-stub.js'

Then you get errors like this:

Cannot import Component because there is no Component export in react. Did you mean import Component from "..."?

But the cause is that the name_mapper has mapped to a file that doesn't export anything.

Direction de recherche: Examinez la logique de résolution des modules dans le code source de Flow. Trouvez où les règles name mapper sont appliquées et ajoutez une vérification pour garantir que le chemin mappé existe. Si ce n'est pas le cas, modifiez le message d'erreur pour inclure le chemin mappé et une suggestion de vérification du .flowconfig.
Stack technique: rust
Domaine: toolingdeveloper experience
Type d'issue: Fonctionnalité
Difficulté: 2
Temps estimé: 1-3 heures
Statut d'activité: Ancienne
Clarté: Claire
Prérequis: FlowJavaScript
Accessibilité débutant: 65