expressjs/multer

Wrong error sometimes for file that's too large?

Open

#405 ouverte le 6 oct. 2016

Voir sur GitHub
 (2 commentaires) (0 réactions) (0 assignés)JavaScript (11 136 stars) (1 043 forks)batch import
futurehelp wanted

Description

Having trouble reproducing this, but for a while today I was receiving a confusing error, 'Unexpected field' (a.k.a. LIMIT_UNEXPECTED_FILE). Searching Stack Overflow I found that this error was mostly caused by a mismatch between the "name" string in the form and the one in my Express route. But that wasn't it because they were both called "image."

I tried re-installing the module but still got the same error. Then I switched to a much smaller file and Multer started working again without the "unexpected field" error. Then, to test my theory I tried uploading a large file, only this time to receive the correct "request entity too large" error.

Also I wonder if there has been discussion of providing an easier-to-understand, separate error message like

"Error: Multer requires a 'name' attribute that matches the one in the route, but received: 'picField'"

Seems like it would save a lot of time for folks...

Guide contributeur

Stack technique
javascriptnodejsexpress
Domaine
backend
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
needs investigation
Prérequis
Node.jsMulter
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
20
Direction de recherche
Investigate the conditions under which Multer throws LIMIT UNEXPECTED FILE instead of LIMIT FILE SIZE for large files. Review the error handling logic in lib/multer.js and the busboy library to understand how file size limits are enforced. Consider adding a separate error code or improving error messages to distinguish between missing fields and oversized files.