envoyproxy/envoy

Allow option to not emit statsd metrics when reporting a `0` value

Open

#6 205 ouverte le 7 mars 2019

Voir sur GitHub
 (4 commentaires) (0 réactions) (0 assignés)C++ (5 373 forks)batch import
enhancementhelp wanted

Métriques du dépôt

Stars
 (27 997 stars)
Métriques de merge PR
 (Merge moyen 8j) (378 PRs mergées en 30 j)

Description

We store the statsd metrics envoy emits in a SAAS monitoring tool that charges us based on the number of measurements we store at a particular reporting interval. Some of the metrics we are recording are consistently 0, with occasional spikes when something happens. Here's an example:

image 2019-03-07 at 11 54 16 am

I can see the value in using a 0 value to report "nothing is happening", but our monitoring bill has doubled as a result of adopting envoy(!), and continues to grow as we add more clusters, so we'd like to save some money by not recording measurements we can mostly infer from an absence of data.

That said, the zero values were very helpful when were spiking into adopting envoy, as it allowed us to see which metrics we could expect from envoy. Maybe this should be a configuration option in the StatsMatcher proto?

Guide contributeur