envoyproxy/envoy

integration tests should use simulated time

Ouverte

#4 160 ouverte le 15 août 2018

 (12 commentaires) (0 réaction) (0 personne assignée)C++ (5 373 forks)batch import
help wantedtech debt

Métriques du dépôt

Stars
 (27 997 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

Description:

A slow testing environment causes test failures and flakes, such as the one described in https://github.com/envoyproxy/envoy/issues/4135. It also makes it hard to run tests under a debugger, which, in addition to helping to debug tests, is a strategy I use sometimes to learn code.

My feeling is that the root of this problem (and others) is singleton patterns like: ProdMonotonicTimeSource::instance_

In the past I've used strategies where these get passed downward as the world gets constructed, so singletons are never referenced in code that needs to be tested (or even exist, usually).

My hope is that injecting MonotonicTime refs into key classes in the system will eliminate the need to reference singletons deeply.

Guide contributeur