help wantedtech debt
Métriques du dépôt
- Stars
- (27 997 stars)
- Métriques de merge PR
- (Merge moyen 8j) (378 PRs mergées en 30 j)
Description
Description:
A slow testing environment causes test failures and flakes, such as the one described in https://github.com/envoyproxy/envoy/issues/4135. It also makes it hard to run tests under a debugger, which, in addition to helping to debug tests, is a strategy I use sometimes to learn code.
My feeling is that the root of this problem (and others) is singleton patterns like: ProdMonotonicTimeSource::instance_
In the past I've used strategies where these get passed downward as the world gets constructed, so singletons are never referenced in code that needs to be tested (or even exist, usually).
My hope is that injecting MonotonicTime refs into key classes in the system will eliminate the need to reference singletons deeply.