Lazy evaluation of compression decision in compressor_filter for http response w/o content-length
#21 807 ouverte le 21 juin 2022
Métriques du dépôt
- Stars
- (27 997 stars)
- Métriques de merge PR
- (Merge moyen 8j) (378 PRs mergées en 30 j)
Description
If you are reporting any crash or any potential security issue, do not open an issue in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately.
Title: One line description Buffer response header in compressor_filter and perform compression decision when receiving first data frame (encode_data)
Description:
Describe the issue.
Snap leverages on compressor_filter to perform response compression for gRPC responses. gRPC server doesnt add content-length to response header that the compressor filter will compress small response payload as well , which causes some overhead in egress bandwidth.
What Snap does(already running in prod env) is to perform a lazy evaluation when receiving first data frame instead of buffering all data frames.
Snap want to seek some feedback from envoy community that
- this operation is feasible (Snap can create a draft PR to review later)
- upstream the change to envoy
[optional Relevant Links:]
Any extra documentation required to understand the issue.