Métriques du dépôt
- Stars
- (27 997 stars)
- Métriques de merge PR
- (Merge moyen 8j) (378 PRs mergées en 30 j)
Description
Title: ext_authz to be able to set x-envoy-force-trace
Description:
The documentation states that
If an internal request sets this header, Envoy will modify the generated x-request-id such that it forces traces to be collected.
However, setting this in an
ext_authzwithallowed_upstream_headersdoesn't enable tracing. It does cause anx-request-idresponse header.It would be practical if
ext_authzcould set the tracing state based on user/session configuration since it's already manipulating that data anyway.
Relevant Links:
The code that checks the header is in conn_manager_utility.cc, but I wonder if this condition in conn_manager_impl.cc is what's causing this decision to be re-evaluated after
ext_authz.The
x-request-idresponse header decision doesn't check the trace reason, but explicitly looks at the force header, which explains why that shows up even without tracing.