Send custom key-value pairs in ot-span-context to Zipkin · envoyproxy/envoy#2031

(3 commentaires) (1 réaction) (0 assignés)C++ (5 373 forks)batch import

area/tracingenhancementhelp wanted

Métriques du dépôt

Thanks for maintaining the great project 👍

Envoy does seem to propagate ot-span-context but drops most of the key-values included in it before sending it to Zipkin.

Would it be possible to send those key-values as binary annotations of Zipkin spans? Could I contribute it?

Context:

After looking into code, it turns out that Envoy as of today drops all the keys in ot-span-context other than a few, well-known keys like traceid and spanid, before sending these to Zipkin.
AFAIK, ot-span-context could be populated with "custom" keys and values other than these, e.g. by our apps, to provide additional context throughout multiple spans in single trace.
If Envoy could translate those to corresponding binary annotations in Zipkin spans, we could view those custom key-value pairs from ot-span-context in Zipkin.
FYI, an app like dd-zipkin-proxy allows Datadog to consume Zipkin spans containing arbitrary binary annotations so that it would also help Datadog users.

Direction de recherche: Inspectez le code source dans source/common/tracing/zipkin/tracer.cc, en particulier les lignes 53-114, pour comprendre comment ot span context est analysé et comment les spans Zipkin sont créés. Identifiez où ajouter des paires clé valeur personnalisées en tant qu'annotations binaires. Ensuite, implémentez les modifications nécessaires pour propager ces paires.
Stack technique: cpp
Domaine: observabilitybackend
Type d'issue: Fonctionnalité
Difficulté: 2
Temps estimé: 1-3 heures
Statut d'activité: Active
Clarté: Claire
Prérequis: C++Envoy codebase understandingZipkin tracing
Accessibilité débutant: 45