envoyproxy/envoy
Voir sur GitHub[dataplane] reset ActiveStream::streamInfo().route() when clearRouteCache()
Open
#20 157 ouverte le 1 mars 2022
area/httpbughelp wanted
Métriques du dépôt
- Stars
- (27 997 stars)
- Métriques de merge PR
- (Merge moyen 8j) (378 PRs mergées en 30 j)
Description
Title: reset ActiveStream::streamInfo().route() when clearRouteCache()
Description: There is a gap between the ActiveStreamFilterBase::clearRouteCache and ActiveStreamFilterBase::streamInfo()::route():
whenever we call clearRouteCache(), the {en,de}coder_callback_.route() ONLY!, the streamInfo().route() is NOT updated.
The "new" route() on {en,de}coder_callback_ will be reset when we refreshCachedRoute(), by either explicitly calling it, or calling {en,de}coder_callback_.route().
So after a clearCachedRoute(), the route() on streamInfo is "stale" and will be out-of-date until refreshCachedRoute() is called.
we should explicitly clear/reset streamINfo()::route_ in clearRouteCache()