envoyproxy/envoy

Combine SDS streams to the same server

Open

#10 793 ouverte le 15 avr. 2020

Voir sur GitHub
 (9 commentaires) (0 réactions) (0 assignés)C++ (5 373 forks)batch import
area/xdsenhancementhelp wanted

Métriques du dépôt

Stars
 (27 997 stars)
Métriques de merge PR
 (Merge moyen 8j) (378 PRs mergées en 30 j)

Description

Title: Combine SDS streams to the same server

Description: When Envoy requires multiple SDS resources from the same SDS server, it currently creates a separate stream for each one, rather than creating a single stream and requesting all resources on that stream. It should instead do the latter, since this avoids a lot of per-stream overhead.

A few notes:

  • This problem does not occur if SDS comes from ADS. It is only a problem when not using ADS for SDS.
  • If the SDS server is a GoogleGrpc service, Envoy actually creates not just a separate stream but also a separate gRPC channel for each resource. However, gRPC internally shares connections between channels, so this doesn't actually result in multiple connections, just multiple streams.
  • This is basically the same problem reported in #2943, but that issue is for EDS and this one is for SDS. Ideally, we should have the same solution to both problems by solving this generically for any xDS API.

CC @htuch

Guide contributeur