downshift-js/downshift

[useSelect] Selecting item with spacebar in firefox reopens the menu

Open

#1 197 ouverte le 18 nov. 2020

Voir sur GitHub
 (5 commentaires) (0 réactions) (0 assignés)JavaScript (11 761 stars) (980 forks)batch import
bughelp wantedneeds investigation

Description

  • downshift version: 6.0.6
  • firefox version: 82.0.3

Relevant code or config

Error present in reference implementation: https://www.downshift-js.com/use-select

What you did:

With firefox, open a menu and select an item with the spacebar key

What happened:

The item was selected, but the menu was reopened. Closely inspecting the result of onStateChange it is revelead that on key down the __menu_keydown_space_button__ is emitted, and on key up the __togglebutton_click__ is emitted.

Error is not present in chrome.

Reproduction repository:

Problem description:

Suggested solution:

Guide contributeur

Stack technique
javascriptreact
Domaine
frontendaccessibility
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
React basicskeyboard events understanding
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
65
Direction de recherche
Investigate the event handling for the spacebar key in the useSelect hook, focusing on the difference between Firefox and Chrome. Look at the onKeyDown and onClick handlers, particularly how they interact. The issue mentions that in Firefox, keydown emits ' menu keydown space button ' and keyup emits ' togglebutton click ', which causes the menu to reopen. Check the source code in the downshift repository, likely in the useSelect.js file, to see if there is a missing event.preventDefault() or improper event propagation handling. Also, check if the 'onKeyUp' event needs to be suppressed. The reference implementation at https://www.downshift js.com/use select can be used for reproduction.