dotnet/roslyn

Fixing CS7036 (generate constructor based on base class) should give an option to use Primary Constructor

Ouverte

#74 602 ouverte le 30 juil. 2024

 (4 commentaires) (1 réaction) (0 personne assignée)C# (4 257 forks)batch import
Area-IDEhelp wanted

Métriques du dépôt

Stars
 (20 414 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

Discussed in https://github.com/dotnet/roslyn/discussions/74598

Originally posted by datvm July 30, 2024 I am not sure if this is a duplicate because I think this is a very popular scenario. Assume we have this code:

class BaseClass(CancellationToken ct)
{

}

class DerivedClass : BaseClass
{
}

VS would suggest to "Generate constructor 'DerivedClass(ct)'":

image

After that, VS continues to suggest to use Primary Constructor instead which gives this code:

class DerivedClass(CancellationToken ct) : BaseClass(ct)
{
}

I think the analyzer should merge the two steps into one?

Guide contributeur